Re: [Linux-fbdev-devel] [PATCH v3] [FB] Add the carmine FB driver.

[Bernhard F. <rep...@gm...>]

On Mon, Apr 21, 2008 at 02:07:06PM +0200, Sebastian Siewior wrote:
>From: Sebastian Siewior <bi...@li...>
>
>Basic FB driver for the carmine chip. The driver registers
>two FB devices for the two possible screens.
>The DRAM settings can be be switched via Kconfig (between eval board
>and custom).
>
>Signed-off-by: Sebastian Siewior <bi...@li...>
>---
>Changelog:
>v3: carmine_check_var() can now fail if an invalid parameter for
>    resolution was supplied instead of using default values and keeping
>    an invalid struct fb_info (noticed by Geert Uytterhoeven).
>v2: - s/carime/carmine/ noticed by Hans J. Koch
>    - fb_get_options() isn't used anymore. The initial video can only be
>      supplied via the module parameter (recommended by Jaya Kumar).
>v1: Initial posting
>
> drivers/video/Kconfig          |   23 ++
> drivers/video/Makefile         |    1 +
> drivers/video/carminefb.c      |  801 ++++++++++++++++++++++++++++++++++++++++
> drivers/video/carminefb.h      |   64 ++++
> drivers/video/carminefb_regs.h |  159 ++++++++
> 5 files changed, 1048 insertions(+), 0 deletions(-)
> create mode 100644 drivers/video/carminefb.c
> create mode 100644 drivers/video/carminefb.h
> create mode 100644 drivers/video/carminefb_regs.h
>

>+choice
>+    depends on FB_CARMINE
>+    prompt "DRAM timming"

s/timming/timing/g

>+	/* Set default curor position */

s/curor/cursor/g

>+static void set_display_parameters(struct carmine_fb *par)
>+{
>+	u32 mode;
>+	u32 hdp, vdp, htp, hsp, hsw, vtr, vsp, vsw;
>+
>+	/*
>+	 * display timing. Parameters ae decreased by one because hardware

s/ae/are/

s/ressolution/resolution/g