Re: [Linux-fbdev-devel] [PATCH 5/9] ps3: Preallocate bootmem memory for ps3fb

[Michael E. <mi...@el...>]

On Tue, 2007-01-30 at 09:16 +0100, Geert Uytterhoeven wrote:
> On Tue, 30 Jan 2007, Michael Ellerman wrote:
> > On Thu, 2007-01-25 at 18:50 +0100, Geert Uytterhoeven wrote:
> > > Preallocate bootmem memory for the PS3 frame buffer device, which nee=
ds a
> > > large block of physically-contiguous memory. The size of this memory =
block is
> > > configurable:
> > >   - The config option CONFIG_FB_PS3_DEFAULT_SIZE_M allows to specify =
the
> > >     default amount of memory (in MiB) allocated to the virtual frame =
buffer.
> > >   - The early boot parameter `ps3fb=3Dxxx' allows to override the def=
ault value.
> > >     It will be rounded up to a multiple of 1 MiB, if needed.
> > >=20
> > > Signed-off-by: Geert Uytterhoeven <Gee...@so...>
> > > Signed-off-by: Geoff Levand <geo...@am...>
> >=20
> > Rather than doing the alloc in setup.c, defining a structure to the hol=
d
> > the params, and then exporting the structure - why don't you just do th=
e
> > alloc in the ps3 fb driver code, and have it all private in there?
>=20
> Because at that time it's no longer possible to allocate such a big block=
 of
> memory.

When it's built as a module, yeah I thought you'd say that. Oh well.

cheers

--=20
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person