Re: [Linux-fbdev-devel] [PATCH] radeonfb: fix init/exit section usage

[Randy.Dunlap <rdd...@os...>]

Kronos wrote:
> Il Fri, Jan 07, 2005 at 11:28:07AM -0800, Randy.Dunlap ha scritto: 
> 
>>Fix 3 instances of calling exit section function from text or init:
>>Error: ./drivers/video/aty/radeon_base.o .text refers to 000029e5 
>>R_386_PC32        .exit.text
>>Error: ./drivers/video/aty/radeon_base.o .text refers to 00002a60 
>>R_386_PC32        .exit.text
>>Error: ./drivers/video/aty/radeon_base.o .init.text refers to 00000192 
>>R_386_PC32        .exit.text
>>
>>Signed-off-by: Randy Dunlap <rdd...@os...>
>>
>>diffstat:=
>> drivers/video/aty/radeon_base.c |    2 +-
>> 1 files changed, 1 insertion(+), 1 deletion(-)
>>
>>---
> 
> 
>>diff -Naurp ./drivers/video/aty/radeon_base.c~radeonfb_initexit ./drivers/video/aty/radeon_base.c
>>--- ./drivers/video/aty/radeon_base.c~radeonfb_initexit	2005-01-06 21:18:20.920585008 -0800
>>+++ ./drivers/video/aty/radeon_base.c	2005-01-07 10:30:16.661094480 -0800
>>@@ -261,7 +261,7 @@ static struct backlight_controller radeo
>> 
>> #endif /* CONFIG_PPC_OF */
>> 
>>-static void __devexit radeon_unmap_ROM(struct radeonfb_info *rinfo, struct pci_dev *dev)
>>+static void radeon_unmap_ROM(struct radeonfb_info *rinfo, struct pci_dev *dev)
>> {
>> 	if (!rinfo->bios_seg)
>> 		return;
> 
> 
> I see that radeon_unmap_ROM is called in radeonfb_pci_register (error
> path). Is this the problem?

Yes.  It was called from radeon_map_ROM() [which is __init]
and from radeonfb_pci_register().

> Oh btw, the maintainer of the new radeonfb is Ben Herrenschmidt, not Ani
> Joshi.

OK, thanks for the info.  Be nice if someone would update
MAINTAINERS with that info...

> Luca

-- 
~Randy