Re: [Linux-7110-psion] S7/netBook touchscreen patch v4

[Matthew L. <Mat...@mo...>]

Hi Klaasjan,

I don't know when/if I'll have any more time to spend on this, but to
address your points in reverse order...

> 2. you mentioned at some point that the touchscreen driver file should
>   probably go to the drivers subdir. I would tend to agree with that.

Yes - I think it should live in drivers/input.

I also think that the menuconfig touchscreen option should be moved -
probably into Character Devices next to mice and joysticks, unless
anyone has any better suggestions.

> 1. wouldn't it be better if the ASIC14 SPI code that you put in 
>   netbook_series7.c would go into its own separate file, perhaps in
>   the drivers subdirectory?

I'm not sure where I could put it in drivers.  Suggestions welcome -
but if there's there a directory for helper-chips then I can't find it.

However, unless there's somewhere where it obviously belongs, I think
the ASIC14 code can reasonably stay in arch/arm/mach-sa1100/ because
it's part of the netBook/S7 platform.  But a separate file in the same
dir would make the separation clearer, and it can also be made
optional for people who want minimal systems.

But as I say, I'm not sure how quickly I'll be able to do anything.

-Matthew.


On Sun, Nov 21, 2004, Klaasjan wrote:
> Hi Matthew,
> 
> Thanks for your work on the touchscreen driver. Sorry for not
> responding earlier, I've had little time to spend on the netbook
> recently.
> 
> On Fri, Oct 29, 2004 at 07:07:43PM +0100, Matthew Lewis wrote:
> >  I would be fine about it
> > being included in a general OpenPsion patch - the whole project is
> > still alpha stage, and the touchscreen driver does not have to be
> > compiled in.
> 
> Yes, I will include it in a next -kvd patch.
> My hope is that I will have time for this before the end of the year,
> and by the time 2.4.28-vrs1 has appeared. If anyone else (you?) feels like
> doing this faster than I can, this would also be fine with me.
> 
> > And I'm not entirely convinced that I have put the additions in the
> > preferred places - definitions in the right header files etc.
> 
> You yourself are probably a better judge for this than I am. Anway,
> looking at your patch I have two suggestions:
> 1. wouldn't it be better if the ASIC14 SPI code that you put in 
>   netbook_series7.c would go into its own separate file, perhaps in
>   the drivers subdirectory?
> 2. you mentioned at some point that the touchscreen driver file should probably
>   go to the drivers subdir. I would tend to agree with that.
> 
> Please let me know how you feel about the above suggestions (or simply
> include them in your next patch...)
> 
> Regards,
> Klaasjan
> 
>