Re: [Licq-devel] Patch for OTR encryption

[Jon K. <jon...@gm...>]

Thanks for resending it. I took a look at it and here are my thoughts..

On 2/8/06, Martin Garbe <mar...@un...> wrote:
> include/licq_otr.h
> src/otr.cpp
> - define a new class COTRHelper with Encrypt(), Decrypt() ...

Historically, all parts of Licq that required a USER/PPID pair have
been with the user first then the PPID. I'd like ot keep this
consistent to simplify things.

> - define ProtoOtr...() functions. These functions are the interface to
> the UI. The UI can call these functions to open, close secure
> connections and generate a private key for the user.
> ProtoOtrDisplaySystemMessage() is used by COTRHelper to send Messages to
> the UI.

Once again, ID then PPID. Also, you have some unsigned long nUin
functions. You don't need those. The only reason they are in the
daemon now is to be compatible with older plugins. Eventually those
functions will be removed from the daemon. They should be marked as
deprecated in the source as well.

> include/licq_user.h
> - ICQUser has a variable OTRMode. Possible values are
>   * "OPPORTUNISTIC" - mark outgoing messages so, that others know you
> offer OTR and if others offer OTR to you then make secure connection
> automatically
>   * "MANUAL" - no automatically secured connection, only manual
>   * "ALWAYS" - no unsecured connection possible
>   * "NEVER" - never secure connection =3D=3D deactivate
> - ICQOwner has a variable bool UseOTRUserSpecific. If it's false use the
> Owners OTRMode for all connection. If it's false look at the users
> OTRModes to distinguish the Otr policy.

Hmm, I think it is better to create a constant and use integers for
this. It's faster and uses less memory. (If you have 900 users it
could make a little difference).


> I think it's a good idea to write messages like "connection secured",
> "connection insecured" and so on directly into the conversation window
> of the user. So the user knows exactly at which point a connection gets
> secured and no extra windows needs to pop up. These system messages
> should have a different color than these of the users.

Just like how the MSN plugin puts a neon green notice when users join
and leave the conversation. That really needs to be an option, which I
will make in the future. So, this too needs to be an option. Depending
on how they are seeing the messages there can be a [DE-] or something
like that in the messages that are encrypted. (E means Encrypted).

And just one last note... the only thing I'm really anal about is the
braces.. I saw some parts that had:

if (x) { // comment
 statement;
}

Just take a look at licq/doc/README.CodingStyle :)

If you plan to modify these things please let me know because if not,
I will to have to do them myself.

Jon

________________________________________________________
Jon Keating                ICQ: 16325723
jo...@li...               MSN: kea...@ho...
http://www.licq.org        GPG: 2290A71F
http://www.thejon.org      HOME: Minamiashigara, Japan