Re: [Libvncserver-common] [PATCH] LibVNCClient: Add H.264 encoding for framebuffer updates

[Johannes S. <Joh...@gm...>]

Hi Christian,

On Thu, 10 Jan 2013, Christian Beier wrote:

> Am Wed,  9 Jan 2013 13:04:08 +0100
> schrieb David Verbeiren <dav...@in...>:
> 
> > This patch implements support in LibVNCClient for framebuffer updates
> > encoded as H.264 frames. Hardware accelerated decoding is performed
> > using VA API.
> > 
> > This is experimental support to let the community explore the
> > possibilities offered by the potential bandwidth and latency
> > reductions that H.264 encoding allows. This may be particularly useful
> > for use cases such as online gaming, hosted desktops, hosted set top
> > boxes...
> 
> First and foremost, thanks for the contribution! Decoding on the GPU
> sounds neat - do you have some benchmark numbers?
> 
> > 
> > This patch only provides the client side support and is meant to be
> > used with corresponding server-side support, as provided by an
> > upcoming patch for qemu ui/vnc module (to view the display of a
> > virtual machine executing under QEMU).
> 
> Do you plan to submit some patches for libvncserver as well? That'd be
> most appreciated so we don't just have the client side support.
> 
> > 
> > With this H.264-based encoding, if multiple framebuffer update
> > messages are generated for a single server framebuffer modification,
> > the H.264 frame data is sent only with the first update message.
> > Subsequent update framebuffer messages will contain only the
> > coordinates and size of the additional updated regions.
> 
> 
> Some picky technical details regarding the patch:
> 
> * Please add new members and the end of structs to retain ABI
> compatibility
> 
> * The stuff in rfbproto.h doesn't need #ifdes I think
> 
> 
> That's it from me - what do you think, Dscho?

I did not have a close look, and unfortunately lack the time in the
foreseeable future.

But this is so cool, I would love to have it!

Ciao,
Dscho