Re: [Libexif-devel] [libexif-cvs] libexif/libexif exif-data.c, 1.90, 1.91

[Hubert F. <hfi...@te...>]

Jan Patera wrote:
> Hi,
> 
>> don't dereference NULL (CID 4)
> 
> What is CID? Out of curiosity, how were all thes weak places found?

See http://scan.coverity.com/
These are defect found by coverity. Since there were a total of 5
defect, including one I consider false, I didn't deem necessary to post
about it. My bad.

>> @@ -193,7 +193,13 @@ exif_data_load_data_entry (ExifData *dat
>>
>>  	/* If this is the MakerNote, remember the offset */
>>  	if (entry->tag == EXIF_TAG_MAKER_NOTE) {
>> -		if (entry->size > 6) exif_log (data->priv->log,
>> +		if (entry->data) {
> 
> This will certainly cause a dereference of NULL (below) in case entry->data
> really is NULL.


OOps, typo. Good catch.
Thanks.

Hub