From: Lutz <lu...@us...> - 2004-05-02 20:46:04
|
On Thu, 2004-04-22 at 22:30, Antonio Scuri wrote: > 1) Would be very nice to have a function like: >=20 > const char * > exif_tag_get_name_index (unsigned int i, ExifTag *tag) Why don't you scan like this:=20 for (i =3D 0; i < 0xffff; i++) if (exif_tag_get_name (i) !=3D NULL) (...) > 2) The file "exif-data.c" depends on the header file "jpeg-marker.h" th= at=20 > it is in the pack, but outside the library folder. Why not to move this= =20 > header to the libexif folder? Actually, the include statement can be replaced by 2 defines (JPEG_MARKER_*). Patches are welcome. >=20 > Also Open Watcom complained about it: >=20 > libjpeg/jpeg-marker.h(27): Error! E1115: Incomplete enum declaration >=20 > I change to the old version. Fixed. > 3) I created a simple "_stdint.h" by hand from Cygwin "stdint.h", all t= he=20 > platforms I use the types used have fixed sizes. The "_stdint.h" is a g= ood=20 > solution for the library users. I am not sure but I think people are currently trying to fix that (or have already been done it). > 4) I still use the same "config.h" that I mention before: >=20 > #define GETTEXT_PACKAGE "libexif-9" >=20 > #ifdef WIN32 > #define snprintf _snprintf > #endif On my system, config.h gets created by autoheader. I am not sure what the official (GNU whatever) way is for handling this on WIN32. > 5) I have to edit the function exif_entry_initialize from "exif-entry.c= ".=20 > There are lots of uninitialized tags. I simply replace the function wit= h my=20 > version. Then saving exif tags in jpeg came back to normal. What is your version? Could you produce a patch against CVS? Regards Lutz M=FCller |