From: Niek B. <ni...@go...> - 2008-09-26 13:55:22
|
Hi Marcus, Sure thing. Here is the new version of the patch. Regards, Niek Bergboer Google Switzerland GmbH Identifikationsnummer: CH-020.4.028.116-1 On Fri, Sep 26, 2008 at 3:18 PM, Marcus Meissner <ma...@je...> wrote: > On Thu, Sep 25, 2008 at 12:20:06PM +0200, Niek Bergboer wrote: >> Hi developers, >> >> Please find a patch attached to this mail that solves a couple of >> memory-corruption issues, and a couple of 64-bit mode options. >> >> The "unsigned int" -> "size_t" type changes are 64-bit fixes; when not >> using these, one gets offsets in the > 2^31 range at times. >> >> The changes to exif-data.c prevent reading from e->data when e->data >> is NULL, and to prevent calling exif_data_save_data_entry if >> ifd->entries[j] is NULL. >> >> An additional set of changes within the maker-note files are to >> prevent crashing on sizes > 64kb; It seems that the maker-notes, at >> times, return sizes that are huge (as in: way beyond 2^31 bytes). >> According to the documentation, though, the full size of the EXIF data >> should fit within a JPEG section, thus intrinsically limiting it to 64 >> kb. I.e.: any s that is > 64 kb indicates a problem within the data. > > Is this diff the right way round? It seems you diffed new -> old > instead of old -> new > > Also please use diff -u > > Ciao, Marcus > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > libexif-devel mailing list > lib...@li... > https://lists.sourceforge.net/lists/listinfo/libexif-devel > |