From: Bernhard K. <bk...@su...> - 2008-06-30 10:20:50
|
On Sat, 28 Jun 2008, Olivier Croquette wrote: > > Hi all > > Here is the corresponding patch for splitdv, with the man page. > Comments (or inclusion :)) welcome. > > I can't test the integration in the libdv build chain, I still have > difficulties unterstanding the autotools... Does not look bad at least. You should be able to test the integration into the libdv build chain (which uses the GNU autotools) by running for example these commands in a copy of your changed libdv directory: libtoolize --copy --force automake autoconf ./configure ... make This should rebuild the libdv autotools build setup and build libdv with them. If you get a working splitdv binary from them, at least the most important basics should be ok. Did you get an answer from Dan Dennedy <da...@de...> about including the patch? About the license, I saw that you agreed to license it under LGPL v2.1 using the same license header as the other C files of libdv: Bernhard Kaindl wrote: >Olivier Croquette wrote: >> Just to not complicate things for adding one utility, I'd prefer if you would >> license dvsplit under LGPL v2.1 using the same license header as the other C >> files use. > > Sure, I don't really care. I just saw that you didn't replace the license header of splitdv.c: + dvsplit.c + + Copyright (C) Olivier Croquette, 2008 + + This program is free software: you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation, version 3. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. The header should look similar to this one (referring to LGPL v2.1): * splitdv.c * * Copyright (C) Olivier Croquette, 2008 * * This file is part of libdv, a free DV (IEC 61834/SMPTE 314M) * codec. * * libdv is free software; you can redistribute it and/or modify it * under the terms of the GNU Lesser Public License as published by * the Free Software Foundation; either version 2.1, or (at your * option) any later version. * * libdv is distributed in the hope that it will be useful, but * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser Public License for more details. * * You should have received a copy of the GNU Lesser Public License * along with libdv; see the file COPYING. If not, write to * the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA. * * The libdv homepage is http://libdv.sourceforge.net/. Sourceforge also has a section "patches" (below Tracker) which where you can publish the final patch using an (free) developer account at sf.net: http://sourceforge.net/tracker/?group_id=4393&atid=304393 Bernhard |