Re: [libdc] [libdc1394-devel] #include in dc1394/utils.h

[David M. <dcm@MIT.EDU>]

On Thu, 2007-11-29 at 22:20 -0500, David Moore wrote:
> On Fri, 2007-11-30 at 11:08 +0900, Damien Douxchamps wrote:
> > On Tue, 2007-09-25 at 12:07 +1200, Johann Schoonees wrote:
> > > Line 27 of dc1394/utils.h (libdc1394-2.0.0-rc7) currently reads:
> > > 
> > > #include <dc1394/control.h>
> > > 
> > > It should probably be:
> > > 
> > > #include "control.h"
> > 
> > Thanks, it's fixed (SVN 464)
> > 
> 
> Actually, I think it was correct the old way.
> 
> If a user includes utils.h in their application outside the libdc1394
> tree, the old way will compile but the new way will fail.
> 

I partially take that back:  it probably won't fail, but I think the old
way was better style-wise, since this header file is a publicly visible
system header, not a user header.  Look at the contents
of /usr/include/glib-2.0/glib for example to see how they do it.

-David