Re: [libdc1394-devel] MS Windows patch: avoiding clutter
Capture and control API for IIDC compliant cameras
Brought to you by:
ddouxchamps,
gordp
From: Damien D. <ddo...@is...> - 2007-08-11 06:43:05
|
Hi Vladimir, On Fri, 2007-08-10 at 18:48 -0700, Vladimir Avdonin wrote: > Hi, I submitted new version of patch to sf patch tracker. It > removes the dll export prefix by exporting all symbols. It is updated to svn > head as OK, at least I can read the 3 first lines of your email ;) Anyway, many thanks for the update, it's *much* better this way. A couple of minor questions: 1) regarding the new function "dc1394_free()". I don't fully understand why it's necessary, but I'm not a C guru so I will let other tell what they think about it. However, if it is indeed required then its name should be more descriptive. Currently it looks like anything can be freed by this function, while the intent is to free camera structs only. Or maybe to free the camera vector (64 in length)? Please clarify. 2) why are error handling macros not compiled for windows? Do you have a replacing error handling mechanism? 3) in dc1394/Makefile.am, "msw" has replaced "juju" in the definition of DIST_SUBDIRS. I suppose that it's a typo and that msw should be added ;) If no one has other comments I will merge the patch as soon as these points are clarified. Thanks, Damien -- _ Damien 高原 Douxchamps ('- Assistant Professor //\ Image Processing Laboratory, NAIST V_/_ http://damien.douxchamps.net/ |