Re: [Lib2geom-devel] Normalizing a Pw<D2<SB>>

[Dr N. H. <nj...@nj...>]

On Sun, Jul 04, 2010 at 06:22:15AM +0200, Krzysztof Kosiński wrote:
> W dniu 4 lipca 2010 06:11 użytkownik Krzysztof Kosiński
> <twe...@gm...> napisał:
> > 2010/6/30 Dr Nathan Hurst <nj...@nj...>:
> >> Actually, I have a merged version of all their changes, but tweenk's
> >> Angle class is buggy (or at least it has different assumptions to the
> >> svg elliptical arc code) and I haven't had the fortitude to work out
> >> what the exact problem is.
> >
> > Oops, I indeed broke elliptical arcs.
> >
> > It was two issues actually:
> > 1. The default conversion between Angle and doubles was a thinko - I
> > added pi instead of 2*pi.
> > 2. While refactoring EllipticalArc, I introduced an error in the
> > calculation of the center.
> >
> > Right now (r2055) elliptical arcs should work correctly.

Thanks, I'll take a look and finish my merge with inkscape head.

> While we're at it, what's the best name for methods of Angle that
> return the angle in various conventions? Currently the names are:
> - radians()
> - radians0()
> - degrees()
> - degreesClock()
> Maybe those shorter names are better?
> - rad()
> - prad() or rad0()
> - deg()
> - clock()

I'm not clear what clock means, but I think your current names are
probably better (descriptive is probably better).

njh