[Lame-dev] [ lame-Bugs-1430719 ] Wave output via stdout header issue

[SourceForge.net <no...@so...>]

Bugs item #1430719, was opened at 2006-02-14 00:35
Message generated for change (Comment added) made by takehiro
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100290&aid=1430719&group_id=290

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Frontends (lame/mp3x/...)
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Wave output via stdout header issue

Initial Comment:
When directing wave output via stdout, LAME currently
performs an fseek and attempts to rewrite the header
with the correct number of samples, file size, etc.

When attempting to pipe the output to another encoder
this results in 11 extra samples at the end of the file
and a nice loud 'click' as the data is simply appended
to the stream.

When directing output via stdout, surely no attempt
should be made to rewrite the header data?

The additional test included below at the end of the
lame_decoder function in main.c resolves this:

    if (0 == disable_wav_header)
        if (0 != strcmp("-", outPath)) //extra test
            if (!fseek(outf, 0l, SEEK_SET)) /* if outf
is seekable, rewind and adjust length */
                WriteWaveHeader(outf, (int) wavsize,
lame_get_in_samplerate(gfp), tmp_num_channels, 16);

From: joh...@nt...

----------------------------------------------------------------------

>Comment By: Takehiro TOMINAGA (takehiro)
Date: 2006-02-19 01:35

Message:
Logged In: YES 
user_id=1071

Thanx! I committed your patch.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=100290&aid=1430719&group_id=290