Re: [Lame-dev] Problems in 3.94alphas

[Takehiro T. <tak...@in...>]

JohnV wrote:
>nspsytune vbr: (test with --nspsytune -V5 -q[x])
>Crackles with fatboy.wav with default noise shaping type 2
>-Z (noise shaping type 1) gets rid of crackles.

Once more, thank you reporting.

From this report, I surveied the "noise shaping type 2" code much,
and I found the bug in subblock gain handling code.

When noise shaping type is 2, LAME enables these 2 features to archive
the "large scalefactor(quantization factor) range".

1) scalefactor scaling (for all the block type)
2) subblock gain (only for the short block)

A bug in 1) has been debugged after 3.93.
A bug in 2) is 'enbugged' after 3.94 early alphas (Oops!).

This fix brings much better result with fatboy.wav + --nspsytune -V5,
but not perfect. I think the rest of problem is in psymodel.

And, we have below TODOs before bumping up the version, so one more wait
please for testing new alphas.

1) add --short-threshold options
2) improve better ATH adjustment in psymodel
3) fix ns_msfix()
-- 
Takehiro TOMINAGA // may the source be with you!