Re: [Kgdb-bugreport] [PATCH] kdb: Fix handling of kallsyms_symbol_next() return value
Status: Beta
Brought to you by:
jwessel
From: Jason W. <jas...@wi...> - 2015-03-03 03:26:15
|
On 03/02/2015 08:13 AM, Daniel Thompson wrote: > kallsyms_symbol_next() returns a boolean (true on success). Currently > kdb_read() tests the return value with an inequality that > unconditionally evaluates to true. > > This is fixed in the obvious way and, since the conditional branch is > supposed to be unreachable, we also add a WARN_ON(). > Thanks. Applied to kgdb-next. I'll send it along to the upstream before the end of the v4.0 cycle, we'll see if we pickup any other fixes along the way. :-) Cheers, Jason. |