Re: [Kaffeine-devel] Patch : adding count-down timer option to a playing entry

[Gillat A. <gi...@ne...>]

J=C3=BCrgen Kofler wrote:

>Hi,
>
>First: Great! I love it :-)=20
> =20
>
I'm pleased you love it.

>>Contents of this patch:
>>
>>1) Fix to the position slider & mouse wheel when seeking backward. =
no
>>more 23:59:00 when seeking down.
>>
>>2) Length of track was incorrect when titles changed on DVD and VCD=
. fixed.
>>   =20
>>
>
>Ok.
>
> =20
>
>>3) Adds the count-down timer that was in kaffeine 0.43b, but was re=
moved
>>from 0.5-rc1.
>>
>>4) Adds OSD timer counter when watching movies (to see how much tim=
e is
>>it to the end :-) ).
>>   =20
>>
>
>Nice.
>
> =20
>
>>* option 3&4 uses the same button to engage.
>>
>>Short click on button - toggles option 3 (Count up/Count Down).
>>
>>Long click on button - toggles option 4 (Osd on/off).
>>   =20
>>
>
>Isn't one second too much for the long click? Wouldn't 500 ms enough=
?
>
>BTW, i noticed a strange behaviour: After switching back from fullsc=
reen the=20
>separator between position slider and the timer button is gone... Ca=
n you=20
>reproduce that?=20
>
Frankly,  one second it really too much (I noticed it before). You=
=20
should put whatever you feel is right.


About the separator thing, it happens to me too. However, the separat=
or=20
is not gone it moved "after" the pushbutton.

A strange behavior happens also in the main toolbar, if you add/remov=
e a=20
button from the main kaffeine toolbar, the separator moves. (try also=
 to=20
change kaffeine engine and return to the kaffeine engine).

Maybe it is a problem with KDE.


Regard,

        Assaf