Re: [kaffeine-devel] EPG search/filter

[Christoph P. <chr...@gm...>]

Hi,

2010/9/12 Dmytro Poplavskiy <dmi...@gm...>:
> Hello,
>
> I have attached the simple patch for EPG filter
> which allows to search for programs in all the channels.

Thanks. I've modified the patch a bit
- using KLineEdit instead of KComboBox
- showing a "Search:" label next to it
- using a QStringMatcher for filtering
- not using a timer for filtering (dynamic filtering should happen at
addEvent, no need to always refilter everything)
- replaced "reset" with remove-all-rows - insert-new-rows
(QItemSelectionModel and QHeaderView behave better)
and committed it.

> I planned to have a list of "Favourite" programs
> (placed below the list of channels) in addition to simple search box,
> but the search box alone is also useful.

Yeah, it looks nice. Searching could also be performed in a second
dialog, but I think the current solution is ok.

> I also changed programs list and description to follow
> selection of channel/program, so it's not necessary to click
> on each program but possible to use keyboard.

Just a little note: you can re-use the existing selection model, you
don't need to create a new one.

> Regards
>  Dmytro.

Thanks again,

Christoph