Re: [kaffeine-devel] [PATCH] ATSC scanning support

[Christophe T. <hf...@fr...>]

Le Tuesday 24 June 2008 03:19:22 Devin Heitmueller, vous avez écrit :
> Hello,
>
> Attached is a patch to provide ATSC scanning support.  Tested with an
> HVR-950 in New York, it is providing identical results to both the
> scan provided in dvb-apps as well as Elgato EyeTV.  Also compared the
> resulting output against the results of the atsc converter tool
> referred to in README.atsc.
>
> I would appreciate it if the patch could be reviewed and considered
> for inclusion.  Comments are certainly welcomed.
>
> Known issues:
>
> * Closed captioning not yet supported.
> * Expects there to be an "atsc" directory containing the transponder
> files in .kde/share/apps/kaffeine (normally provided by
> dvbdata.tar.gz).  I copied the content from the dvb-apps version of
> the transponder files.  This solution would expect dvbdata.tar.gz to
> start providing the ATSC transponder files.
> * Not fully validated with multi-lingual AC3 audio streams (but
> appears to be working at initial testing)
> * Not validated with CVCT (Cable/QAM).  Only tested with over the air
> ATSC (TVCT)
> * An additional digit has been added to the channel number, so sorting
> works properly (now 5 digits instead of 4).  We probably eventually
> need a better way to support subchannels when it comes to sorting but
> this works for now.
>
> There is certainly some more cleanup/restructuring that could be done
> in terms of sharing code between the ATSC and DVB support, but my goal
> at this point was to provide a patch that incurs minimal impact on the
> existing DVB functionality (since I can't test those parts).
>
> Thanks,

Hi Devin,

this patch is very much appreciated, finally an atsc user did it :)
Kaffeine kde3 branch was closed with 0.8.6, but i will release a 0.8.6b to 
give atsc users full atsc support.
I'm ccing Christoph Pfister so hopefully he finds some time to update the 
dvbdata with atsc dir ;)

Thanx again.

-- 
Christophe Thommeret