[Jython-bugs] [ jython-Patches-1664366 ] Patch for [1648449] os.path.normcase broken in Windows

[SourceForge.net <no...@so...>]

Patches item #1664366, was opened at 2007-02-20 09:26
Message generated for change (Comment added) made by fwierzbicki
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=312867&aid=1664366&group_id=12867

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Closed
Resolution: Rejected
Priority: 5
Private: No
Submitted By: howard kapustein (hsk0)
>Assigned to: Nobody/Anonymous (nobody)
Summary: Patch for [1648449] os.path.normcase broken in Windows

Initial Comment:
javaos unconditionally imports javapath as os.path
This breaks several things as javaos doesn't properly implement several os.path functions, relies on the underlying live system at the moment instead of purely definitional expectations, and fundamentally provides a different model of os.path than CPython does (always loads javapath=os.path, instead of conditionally making os.path=ntpath, posixpath, macpath, etc).

You can see the full details in my comments to the bug
http://sourceforge.net/tracker/index.php?func=detail&aid=1648449&group_id=12867&atid=112867

This patch also fixes
[1661700] os.path.abspath raises IOException if drive not accessible

See my comments on that bug as well for why
http://sourceforge.net/tracker/index.php?func=detail&aid=1661700&group_id=12867&atid=112867

This likely fixes other problems as well.

javaos.py is from Jython 2.2b1
javaoshk.py has my modifications
Here's the diff
--------------------
[~] diff -u javaos.py javaoshk.py
--- javaos.py   2007-02-20 09:06:22.000000000 -0500
+++ javaoshk.py 2007-02-20 09:08:35.000000000 -0500
@@ -28,9 +28,29 @@

 import java
 from java.io import File
-import javapath as path
 from UserDict import UserDict

+# Load the right flavor of os.path
+_osname = None
+_jythonospath = java.lang.System.getProperty('jython.os.path')
+if _jythonospath:
+    _jythonospath =  _jythonospath.lower()
+    if _jythonospath in ['java', 'dos', 'mac', 'nt', 'posix']:
+        _osname = _jythonospath
+if _osname == None:
+    _osname = java.lang.System.getProperty('os.name').lower()
+if _osname == 'nt' or  _osname.startswith('windows'):
+    import ntpath as path
+elif _osname.startswith('mac') and not _osname.endswith('x'):
+    import macpath as path
+elif _osname == 'dos':
+    import dospath as path
+elif (_osname == 'posix') or ((File.pathSeparator == ':') and ('vms' not
+in _osname) and (not _osname.startswith('mac') or _osname.endswith('x'))):
+    import posixpath as path
+else:
+    import javapath as path
+
 class stat_result:
   import stat as _stat


----------------------------------------------------------------------

>Comment By: Frank Wierzbicki (fwierzbicki)
Date: 2007-07-21 09:46

Message:
Logged In: YES 
user_id=193969
Originator: NO

oops -- I didn't notice this was closed.

----------------------------------------------------------------------

Comment By: Charles Groves (cgroves)
Date: 2007-05-14 02:06

Message:
Logged In: YES 
user_id=1174327
Originator: NO

Unfortunately the platform specific path modules expect os.stat to work
properly, which isn't the case due to Java limitations.  Until that's
addressed we can't just use them as javapath has Java specific workarounds
that don't use stat.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=312867&aid=1664366&group_id=12867