Re: [Jython-dev] zxJDBC into Jython

[<bc...@wo...>]

[brian]

>Since I'm not sure who's interested, I thought I'd just mail the group.
>
>I finally rolled zxJDBC into the Jython mainline.  

And thank you for that.

>I wanted to bring to your attention the following:
>
>* I added a top-level directory 'com'
>
>* I added two new files to 'Lib', dbexts.py and isql.py.
>
>* I made some changes to build.xml.  In particular:
>  - I moved the reading of ant.properties to the beginning so local vars
>can override global ones.
>  - I added additional conditional compilations of zxJDBC datahandlers.
>If you do not have the correct JDBC drivers (such as MySQL, Oracle,
>Postgresql, ...) they will not compile.  This really has no affect for
>general development, but they should get compiled for releases.  I can
>help gather the JDBC drivers as needed.  If there is a licensing issue
>with this, I can make them available outside of the core release.

Some of the drives must be available freely on the net. Tell us about
the links you already have.

>  - I added five new properties to ant.properties (again, these can be
>safely ignored) as referenced in the 'main.classpath' path element.

Please update the Doc/compile.ht file with a list of the new properties.

>* I have numerous pyunit tests that I have not checked in yet.  I'm
>deciding on the best way to handle it.  One problem with developing
>across so many db's is testing them since you have to have running
>instances.  For the time being I'll handle testing manually.

We really should get our testing more together. It seems like we have to
run the tests in:

- Lib/test/testall.py
- bugtests/driver.py
- Some of the tests in CPython's Lib/tests
- and now some zxJDBC tests.

>* I have not checked in any documentation.  I would like to re-style it
>to fit into whatever flavor the rest of the Jython documentation uses.
>
>* In installer/mklist.py, the 'javafiles' filter does not include the
>*.dat nor the new *.properties files, should it? 

Yes, either that or maybe add a new 'zxJDBCfiles' filter.

>On this note, I added
>the new top-level 'com' package and its subdirectories as needed.  I did
>not check in an update version of the generated files in that directory,
>should I have?

Yes, but only if the generated liftoff.filelist does not deviate severly
from the CVS version. At least you should try to run it, because your
checkin contains a little typo. 

>* Please let me know if something doesn't compile.

I get a warning with jikes-1.15:

    [javac] Compiling 217 source files to D:\jython\CVS\build
    [javac]
    [javac] Issued 1 semantic warning compiling
"D:/jython/CVS/com/ziclix/python/sql/PyCursor.java":
    [javac]
    [javac]     59.             } catch (Exception e) {}
    [javac]                                  <--------->
    [javac] *** Caution: This try block cannot throw a "checked
exception" (JLS section 14.7) that can be caught here. You may have
intended to catch a RuntimeException instead of an Exception.

>I have only compiled
>under 1.3 and 1.4, so I hope that it works on an earlier VM (is anyone
>still using one?).

Yes. It is fundamental requirement for me that jython also compiles and
runs on java1. I don't demand that all new feature is backward
compatible all the way down to JDK1.1 but the jython sources should
still compile cleanly on JDK1.1.

The <exclude name=".."> thing does not work for me. If I rewrite the
exclude to 
   <javac .... excludes="${exclude.java2.files}">
It compiles again for JDK1.1.  I'm using ant-1.2.

Some of the zxJDBC sources depends on java2 collections (like Map,
HashSet and ArrayList)and JDBC20DataHandler depends on Types.CLOB and
getBigDecimal() and getArray().

It is ok if zxJDBC require java2, then it only have to be part of the
exlude.java2.files property in build.xml.

>* I removed the license information from within all the files.  I kept
>only a personal copyright.

Very good.

In order to avoid a prolonged discussion about the original license of
zxJDBC, you might want to add a note on the license webpage. Or we could
add a LICENSE.txt file to the com/ziclix directory. Thoughs?

regards,
finn