Re: [Jython-dev] new system and environ support in javaos

[<bc...@wo...>]

[Samuele Pedroni]

> Some notes:
>
> - if something goes wrong with Runtime.exec a java exception is thrown,
>  I think this should be somehow wrapped in an os.error. Opinions?

[Kevin Butler]

>Agreed.

Ok, as long as the os.error contain all the information from the java
exception. Including information about the type of exception
(IOException or SecurityException) and the exception message.

The patch below doesn't and it certainly should.

>> - in particular if something goes wrong when populating environ, we should
>>  decide whether to throw an exception or gracefully fall back to a NullEnv.
>
>I'm inclined to throw an OS exception here, too - let the user know that things
>aren't working as expected, and if the user wants to change configuration to use
>NullEnv, that's great.

I agree.

>Should we be trying to provide some sort of meaningful 'errno' codes?  I've just
>been raising OSError( 0...) like the other javaos functions...

Good enough. The IOException thrown from exec() sometimes contain the
operating system error code (as text). 

>> - environ populating does not work (as far as my installation is concerned)
>> with win 98:
>>   "command.com /c set should be invoked, "command /c set" fails.
>
>I get similar behavior on Win95/JDK1.1.8.  (had to dig up my Win95 laptop & install
>a JDK (figured I'd install one I didn't have elsewhere), replace the old jpython
>installation w/ a new jython version, & get the new javaos.py...  Speedy it was
>not...)

Thats why I haven't touched added this feature myself. It is so easy to
get working for oneself but so hard to get it working correctly for all.

>As is becoming all too frequent, here's a patch (but this is the last one for a
>long time...  *wink*),

Do you have a SF account? Make one and I'll add you as committer. Then
you don't have to make excuses every time.

>! pardir = '..'

You think that is right on macs and AS/400? Maybe it actually is, but I
doubt it. I liked the old defensive comment.

>!         except UnboundLocalError:
>!             # 'value' is unbound because we didn't find '=' on first line

Maybe it is just my personal preference, but I would prefer an explicit
test instead of catching UnboundLocalError.

regards,
finn