Re: [Jython-dev] logging library issue + monkey patch fix

[Philip J. <pj...@un...>]

On Jun 14, 2011, at 7:51 AM, Yoav Aner wrote:

> Hello,
> 
> First post to this list, so please excuse any mistakes or lack of knowledge. I'm pretty new to jython (and perhaps not fully understand the relationship with python etc).
> 
> One relatively small issue we've came up with is using the logging library. Things are working fine, but when trying to add the method + line number of the calling function to the log formatter (e.g. %(filename)s:%(funcName)s(%(lineno)d ) then we always seemed to get the line number of __init__.py of the logger itself...
> 
> Upon further investigation, it turned out it happens because __init__.py only looks at .pyc and .pyo files, and ignores $py.class files. Specifically these lines of code:
> 
> if hasattr(sys, 'frozen'): #support for py2exe
>     _srcfile = "logging%s__init__%s" % (os.sep, __file__[-4:])
> elif string.lower(__file__[-4:]) in ['.pyc', '.pyo']:
>     _srcfile = __file__[:-4] + '.py'
> else:
>     _srcfile = __file__
> _srcfile = os.path.normcase(_srcfile)
> 
> 
> If another condition is added, e.g.
> 
> elif __file__.endswith('$py.class'):
>     _srcfile = __file__[:-9] + '.py'
> 
> then it fixes the problem. Not sure if this needs to be reported upstream to python or to the jython dev... Again apologies if this is the wrong place to report this.

Good catch, please log an issue on the tracker. We'll need to apply this to the Jython stdlib and then merge it back to CPython.


--
Philip Jenvey