From: Oti <oh...@gm...> - 2010-03-02 19:31:06
|
Hi Steve, many thanks! I definitely will give it a try. When I tried the last version, I simply created a Run configuration in Eclipse, which automatically included all (or at least: most) of the .jar files in trunk/extlibs. Maybe it was because of that I did not have the posix problem. Next time I'll use the command line, to avoid confusion. best wishes, Oti. On Tue, Mar 2, 2010 at 5:05 AM, Steve Yegge <st...@go...> wrote: > Hi folks, sorry for the delay on this. I've attached a new file that > supercedes/replaces > the previous file I sent out. (Once again I tried submitting it on Jython > Tracker and got a > permissions error.) > The attachment fixes problems with my previous submission: > - added "Licensed to PSF under a Contributor Agreement" in all new files > - fixes to allow the demo app to use CPythonLib as its standard library > - inline the css so there's no trouble with paths > - misc bug fixes in the demo app (NPEs uncovered by indexing CPythonLib) > - merged in a new svn update from a few hours ago > The demo app should pick up an order of magnitude more links now. > (It would still be nice if it showed cross-references -- I'll think about > how to > do that statically for a future release.) > You can use the demo to index all of CPythonLib as follows: > ant jar-complete > java -classpath ./dist/jython.jar org.python.indexer.demos.HtmlDemo > ./CPythonLib ./CPythonLib > This tells it to use CPythonLib for the standard library, and to index > CPythonLib itself. > (This is more interesting than indexing, say, just CPythonLib/email, as it > shows more intra-file links.) > It writes about 1200 html files into ./html (103 mb uncompressed, or 55 mb > with bzip2 compression). > As before, the attachment is a zip of two files: a patch from svn diff, and > a tar.gz of new files. > Thanks for giving it a try! > -steve > On Mon, Feb 8, 2010 at 12:29 PM, Steve Yegge <st...@go...> wrote: >> >> Hi Oti, >> The HTML output needs some love -- the path to the css file is being >> hardcoded >> to your working directory, and the indexer is failing to pick up a lot of >> links, likely >> because I haven't provided the demo with a way to look in Jython for the >> stdlib. >> I'll fix these things and send you a replacement for the patch; I can also >> add in the >> "Licenced to PSF under a Contributor Agreement." to the files per Jim's >> suggestion. >> Thanks, >> -steve >> On Sat, Feb 6, 2010 at 3:58 PM, Oti <oh...@gm...> wrote: >>> >>> Hi Steve and Frank, >>> >>> I have all the tests passing locally, and I believe the build bots >>> would pass as well. >>> >>> What I'd like to ask Steve to check is if the generated .html files are >>> correct. >>> I ran: org.python.indexer.demos.HtmlDemo >>> ${workspace_loc}/jython-trunk/CPythonLib/email/ >>> and then zipped the /html directory into >>> http://bugs.jython.org/file764/html.zip >>> This is the console output: http://bugs.jython.org/msg5507 >>> (both links also can be found behind http://bugs.jython.org/issue1541) >>> >>> And I'd like to ask Frank to review the grammar changes. >>> AFAICS they fit very well. >>> >>> Finally, is the copyright notice >>> "Copyright 2009, Google Inc. All rights reserved." >>> in the added files is OK for Jython? >>> Please excuse my ignorance, but I keep forgetting where the potential >>> legal problems are. >>> >>> I hope I get your thumbs up, and nobody else objects. >>> Then this is ready for checkin. >>> >>> Thanks a lot! >>> Oti >> > > |