From: Oti <oh...@gm...> - 2010-02-06 23:58:52
|
Hi Steve and Frank, I have all the tests passing locally, and I believe the build bots would pass as well. What I'd like to ask Steve to check is if the generated .html files are correct. I ran: org.python.indexer.demos.HtmlDemo ${workspace_loc}/jython-trunk/CPythonLib/email/ and then zipped the /html directory into http://bugs.jython.org/file764/html.zip This is the console output: http://bugs.jython.org/msg5507 (both links also can be found behind http://bugs.jython.org/issue1541) And I'd like to ask Frank to review the grammar changes. AFAICS they fit very well. Finally, is the copyright notice "Copyright 2009, Google Inc. All rights reserved." in the added files is OK for Jython? Please excuse my ignorance, but I keep forgetting where the potential legal problems are. I hope I get your thumbs up, and nobody else objects. Then this is ready for checkin. Thanks a lot! Oti |