From: Oti <oh...@gm...> - 2007-07-30 21:38:07
|
On 7/30/07, Charlie Groves <cha...@gm...> wrote: > On 7/30/07, Oti <oh...@gm...> wrote: > > Charlie, > > > > in general it works as expected, but I do have 2 bigger points / > > questions and some detail ones. Sorry to bother you with nitty-gritty > > details. But in turn I'd take care of build.xml. > > Deal ? > > Nitty-gritty details are encouraged; I sent this here to have some > raised. You don't have to take on maintaining the build all by > yourself to bring them up. Part of what I hoped to accomplish with > the build.xml changes was to make it a little more straightforward to > see what it's doing so anyone can make little changes as need be. > > > 2. 3 regression tests fail unexpectedly > > When calling targets > > - clean > > - developer-build > > - regrtest > > in this order, 3 tests fail: > > [java] 3 fails unexpected on java1.4.2_15: > > [java] test_subclasses test_inspect test_unicode > > Only 3 tests fail on 2.3 for you? You're doing much better than I am. > Even with the current build.xml in place I get more than 20 > unexpected failures on 2.3, those three included. That's what I've > been working on with commenting out bits of tests and filing bugs: > getting 2.3 to a cleanly passing state so I can start breaking things > again. Sorry for the confusion. I meant: 2nd (bigger point), there are 3 regression tests failing unexpectedly on trunk. I have more data and experience to compare on trunk than on the 2.3 branch. > > > On to the smaller questions: > > > > svnant.jar.dir property probably slipped in. I think it should be > > defined in ant.properties. > > So it should. > > > You removed arguments 'optimize' and 'nowarn' in one javac call. > > Probably slipped in, too. > > But I agree with you that the default for 'debug' should be true. > > optimize doesn't do anything: > http://ant.apache.org/manual/CoreTasks/javac.html I don't know why I > deleted nowarn though. > > > Since target developer-build-called went away, it's property should > > not be used any more. > > Sure. > > > If you do not have any objections, I'll proceed on this path, and as > > soon as I get the same test results I'll commit. > > Sounds fine. I'm still pretty distracted by stuff on trunk. I'm almost exclusively working on trunk. Do you think we should leave the build.xml as it is for 2.2, and only change it on 2.3 ? Oti. |