[Jython-dev] Couldn't ByteSwapper ditch reflective class Arrays usage?

[Leo U. <leo...@ya...>]

Hi,

I was just peeking at the ByteSwapper class, really
for no reason, and I noticed the usage of the Arrays
class to set the values for arrays.  For example:
private static void swapIntegerArray(Object array) {
    int len = Array.getLength(array);
    int tmp;
    int b1, b2, b3, b4;
		
    for(int i = 0; i < len; i++) {
        tmp = Array.getInt(array, i);
			
	b1  = (tmp >> 0)  & 0xff;
	b2  = (tmp >> 8)  & 0xff;
	b3  = (tmp >> 16) & 0xff;
	b4  = (tmp >> 24) & 0xff;
	tmp = (int)(b1<<24 | b2<<16 | b3<<8 | b4<<0);
			
	Array.setInt(array, i, tmp);
    }
}

couldn't this be rewritten to a
non-reflective(probably quicker code):
private static void swapIntegerArray(Object array) {
    int[] iarray = (int[])array;
    int len = iarray.length;
    int tmp;
    int b1, b2, b3, b4;
		
    for(int i = 0; i < len; i++) {
        tmp = iarray[i];
			
	b1  = (tmp >> 0)  & 0xff;
	b2  = (tmp >> 8)  & 0xff;
	b3  = (tmp >> 16) & 0xff;
	b4  = (tmp >> 24) & 0xff;
	tmp = (int)(b1<<24 | b2<<16 | b3<<8 | b4<<0);
	iarray[i] = tmp;
    }
}

///////////
leouser


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com