From: Samuele P. <ped...@st...> - 2006-07-17 18:24:48
|
Frank Wierzbicki wrote: > On 7/16/06, Charlie Groves <cha...@gm...> wrote: > >> Hi, >> >> The classic classes that make up the _sre module(PatternObject, >> MatchObject) are missing a few methods. The CPython versions are >> still classic classes in 2.4. Should I just add the methods to the >> classes in the existing classic style, or should I make new style >> classes out of them? Are there any reasons not to use new style >> classes? Are there things it does other than letting user code >> subclass built in types? It looks like the generated methods in >> PyString.java handle the arg checking and default handling that >> MatchObject.java has to do on its own. >> >> I guess I'm trying to see how the new style stuff in Jython lines up >> with the new style stuff in CPython. > > Samuele would be the best one to answer this, but I'll give my opinion > anyway. I think we should go with new-style classes when it turns out > to be easy, even when that puts us "ahead" of CPython, since > everything should ultimately be new-style. I would guess that the > reason CPython classes might still be old-style in 2.4 is probably > internal/technical and not philosophical. > > Samuele? CPython _sre is using old-style types because is still meant to be compilable and work with versions of CPython back to 1.5.x, we don't have such a constraint. > > -Frank PS: I'm sort in vacation and traveling quite a bit until middle of august |