[Junit-trackers] [ junit-Bugs-1815188 ] CompositeRunner.filter incorrect if child throws NoTestsRema

[SourceForge.net <no...@so...>]

Bugs item #1815188, was opened at 2007-10-17 15:49
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115278&aid=1815188&group_id=15278

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Flo (flofh)
Assigned to: Nobody/Anonymous (nobody)
Summary: CompositeRunner.filter incorrect if child throws NoTestsRema

Initial Comment:
is behavior:
The JUnit CompositeRunner does not catch the NoTestsRemainException, so as soon as one of the child runners throws it, all other child runners are ignored.

expected behavior:
The JUnit CompositeRunner should catch the NoTestsRemainExceptions of all its children and remove those of his children.
It should only throw a NoTestsRemainException in the case that it doesn't have children anymore.

current code:
public void filter(Filter filter) throws NoTestsRemainException {
  for (Iterator<Runner> iter= fRunners.iterator(); iter.hasNext();) {
    Runner runner= iter.next();
    if (filter.shouldRun(runner.getDescription()))
      filter.apply(runner);
    else
      iter.remove();
  }
}

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=115278&aid=1815188&group_id=15278