From: SourceForge.net <no...@so...> - 2007-04-24 02:20:17
|
Bugs item #1694441, was opened at 2007-04-04 10:33 Message generated for change (Comment added) made by sf-robot You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=115278&aid=1694441&group_id=15278 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed Resolution: None Priority: 5 Private: No Submitted By: Jonhnny Weslley (jweslley) Assigned to: David Saff (dsaff) Summary: @Ignore on BeforeXXX and AfterXXX Initial Comment: The annotation Ignore no has effect over the methods annotated with Before, BeforeClass, After or AfterClass annotations. ---------------------------------------------------------------------- >Comment By: SourceForge Robot (sf-robot) Date: 2007-04-23 19:20 Message: Logged In: YES user_id=1312539 Originator: NO This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker). ---------------------------------------------------------------------- Comment By: David Saff (dsaff) Date: 2007-04-09 09:55 Message: Logged In: YES user_id=325156 Originator: NO Your code snippet contains (leaving out a valid question about a different open tracker item): @Ignore // I thought this annotation was valid here @BeforeClass /* * I dont want to create a new database schema every time. */ public static void createDataBase() throws Exception { (new SchemaExport(configuration)).create(true, true); } Here, I would be much more comfortable bringing the logic from the comments into the code: @BeforeClass public static void createDataBase() throws Exception { if (schemaNeedsCreating()) (new SchemaExport(configuration)).create(true, true); } Then, schemaNeedsCreating could refer to a compile-time constant or run-time property. Thus, I'm not convinced to have @Ignore work on @BeforeClass. Would it have been helpful to flag that configuration as an error, rather than ignoring the @Ignore? Thanks, David Saff ---------------------------------------------------------------------- Comment By: Jonhnny Weslley (jweslley) Date: 2007-04-09 08:47 Message: Logged In: YES user_id=1627927 Originator: YES I am sending a use case!!! See the comments at createDataBase method. Thanks! File Added: IntDateTimeUserTypeUsageTest.java ---------------------------------------------------------------------- Comment By: David Saff (dsaff) Date: 2007-04-05 13:56 Message: Logged In: YES user_id=325156 Originator: NO Can you provide a use case? What is the situation in which you would choose to ignore a setup method, and then reinstate it? In my experience, my tests are usually meaningless unless all the setup code runs. Thanks! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=115278&aid=1694441&group_id=15278 |