Re: [jmoney-devel] Problems with uninitialized TreeNode

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

Sorry - I think I made this more confusing than it is.  My issue was
initially that the TreeNode was not properly initialized.  I "fixed" that by
hacking in the TreeNode.init() call in NavigationView.  This led me to the
deeper problem that the plug-in never got initialized.  THAT was my
show-stopping issue.  I agree that the hack most likely made the problem
worse.

I was using eclipse 3.1.  I hadn't noticed you guys were using 3.2.  I'm
currently downloading that and a fresh pull from cvs to see if I can get it
to work.

Brian 

-----Original Message-----
From: jmo...@li...
[mailto:jmo...@li...] On Behalf Of Westbury
Sent: Wednesday, August 30, 2006 2:12 AM
To: jmo...@li...
Subject: Re: [jmoney-devel] Problems with uninitialized TreeNode

Brian,

Yes, it does appear that the constructor never ran.  The only way the given
line can give a null pointer exception is if 'plugin' was never set, which
means the constructor never ran.  But then the stack makes no sense because
TreeNode.init is not called from NavigationView.init, so I assume you
inserted a call in order to try to bypass the problem.  It seems like you
are trying too hard to fix the problem, and by changing the code around
things are going from bad to worse.  

I don't understand how the navigation view could be initialized before the
plugin activator class (JMoneyPlugin) is constructed.  Eclipse is up to
something weird here which I have not seen.  I would try a full refresh from
CVS and a clean build.  You say you updated jmoney.product from HEAD.  I
would at least be sure to update the entire tree (personally I have never
done a partial update).  Make sure you have a clean Eclipse 3.2 too.  I am
sorry I can't think of anything else at this time that may be a cause of the
problems.

I have just tried the lastest with Johann's update and I can now run from
the product page and Eclipse 3.2 with no problem.

- Nigel

P.s. If it helps, here are the stacks on my (working) installation:

When the constructor is called:

	at net.sf.jmoney.JMoneyPlugin.<init>(JMoneyPlugin.java:107)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown
Source)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown
Source)
	at java.lang.reflect.Constructor.newInstance(Unknown Source)
	at java.lang.Class.newInstance0(Unknown Source)
	at java.lang.Class.newInstance(Unknown Source)
	at
org.eclipse.osgi.framework.internal.core.AbstractBundle.loadBundleActivator(
AbstractBundle.java:136)
	at
org.eclipse.osgi.framework.internal.core.BundleContextImpl.start(BundleConte
xtImpl.java:966)
	at
org.eclipse.osgi.framework.internal.core.BundleHost.startWorker(BundleHost.j
ava:317)
	at
org.eclipse.osgi.framework.internal.core.AbstractBundle.start(AbstractBundle
.java:256).....

And when the account node is set up in TreeNode.init:

	at net.sf.jmoney.views.TreeNode.init(TreeNode.java:197)
	at net.sf.jmoney.JMoneyPlugin.start(JMoneyPlugin.java:128)
	at
org.eclipse.osgi.framework.internal.core.BundleContextImpl$2.run(BundleConte
xtImpl.java:995)
	at java.security.AccessController.doPrivileged(Native Method)
	at
org.eclipse.osgi.framework.internal.core.BundleContextImpl.startActivator(Bu
ndleContextImpl.java:989)
	at
org.eclipse.osgi.framework.internal.core.BundleContextImpl.start(BundleConte
xtImpl.java:970)
	at
org.eclipse.osgi.framework.internal.core.BundleHost.startWorker(BundleHost.j
ava:317)
	at
org.eclipse.osgi.framework.internal.core.AbstractBundle.start(AbstractBundle
.java:256)........

I am so sorry you are having this problem.  As you said, it should not be
this difficult!  Let's hope a simple refresh or something does the trick.

- Nigel

-----Original Message-----
From: jmo...@li...
[mailto:jmo...@li...] On Behalf Of Brian
Sweeney
Sent: Tuesday, August 29, 2006 8:22 PM
To: jmo...@li...
Subject: Re: [jmoney-devel] Problems with uninitialized TreeNode

Digging a little deeper, it appears that the JMoneyPlugin hasn't really been
initialized (constructor never ran).  A system.err print will confirm this.
Is that intentional?  That's preventing all of my property sets from being
found, but more importantly, it is shooting a NPE up the stack.  Any
thoughts?

java.lang.NullPointerException
	at
net.sf.jmoney.JMoneyPlugin.getResourceString(JMoneyPlugin.java:145)
	at net.sf.jmoney.views.TreeNode.init(TreeNode.java:197)
	at net.sf.jmoney.views.NavigationView.init(NavigationView.java:290)
	at
org.eclipse.ui.internal.ViewReference.createPartHelper(ViewReference.java:28
0) 

Brian Sweeney

-----Original Message-----
From: jmo...@li...
[mailto:jmo...@li...] On Behalf Of Brian
Sweeney
Sent: Tuesday, August 29, 2006 10:50 PM
To: jmo...@li...
Subject: [jmoney-devel] Problems with uninitialized TreeNode

Loading up the newly checked-in version of Jmoney, I've run across a small
startup problem.  

NavigationView throws an error when the accountsRootNode is null (I assume
this is because I have no accounts defined).  I can fix this with a simple
null check and call to init(), but that seems to be a poorly architected
solution.  There is a call on line 123 of JMoneyPlugin.java, but a
breakpoint + debug mode revealed that the call was not being run for some
reason.  I'm not familiar enough with the eclipse plugin architecture to
know why that is.  

Relavent stack trace:
java.lang.NullPointerException
	at net.sf.jmoney.views.NavigationView.init(NavigationView.java:292)
	at
org.eclipse.ui.internal.ViewReference.createPartHelper(ViewReference.java:28
0)

Just wanted to let you guys know,
Brian

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job
easier Download IBM WebSphere Application Server v.1.0.1 based on Apache
Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
jmoney-devel mailing list
jmo...@li...
https://lists.sourceforge.net/lists/listinfo/jmoney-devel

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job
easier Download IBM WebSphere Application Server v.1.0.1 based on Apache
Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
jmoney-devel mailing list
jmo...@li...
https://lists.sourceforge.net/lists/listinfo/jmoney-devel

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job
easier Download IBM WebSphere Application Server v.1.0.1 based on Apache
Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
jmoney-devel mailing list
jmo...@li...
https://lists.sourceforge.net/lists/listinfo/jmoney-devel