Re: [jmoney-devel] model2 questions

[javaman <ja...@mi...>]

Hi Johann,

Thanks for your comments.

The reason I had split Currency into Commodity and Currency was  because I anticipated that plug-ins would be written to keep track of assets other than currency accounts.  For example, stock accounts could contain stock.  The split allowed such other assets to be easily added by plug-ins.

I agree with your comments on changing class names to follow the Eclipse conventions.  Part of the reason much of the code does not follow the Eclipse conventions was that it was written before we moved over to Eclipse and before I was familiar with the Eclipse conventions.

The mutable interfaces are a mess.  I totally agree with you, and I want to clear these out.  The problem is that if the datastore is transaction based, how does the datastore know when to commit changes?  I originally introduced the mutable classes to solve this problem when experimenting with JDO.  I have rejected JDO as a usable solution, but the classes still remain and solve the same problem for JDBC databases.  I do need to come up with a plan that enables us to remove these horrible mutable classes.

- Nigel




, or perhaps assets such as property might be tracked so that capital gains and rates of return on investments 



   -------Original Message-------
   > From: Johann Gyger <jo...@gy...>
   > Subject: [jmoney-devel] model2 questions
   > Sent: 12 Sep 2004 20:33:22
   >
   >  Hi again, Nigel
   >  
   >  While browsing the new data model of JMoney I have found some design
   >  questions/proposals. First of all forget the question about nested
   >  accounts in my last email - it's already there. The transaction
   >  approach is very good and I should have done it like that right from
   >  the start.
   >  
   >  Commodity: Why did you introduce this interface? Do you have other
   >  interfaces in mind besides Currency? (Currency seems to be the only
   >  heir of Commodity.)
   >  
   >  Mutable classes: Why do you distinguish mutable and immutable classes
   >  (e.g. CapitalAccount and MutableCapitalAccount)? In my opinion this
   >  complicates the simple data model of JMoney.
   >  
   >  Iterators: In interface Session you define iterator accessors instead
   >  of returning a collection/list/whatever. What is the advantage of this
   >  approach? Clearly, the client doesn't get full access to a collection
   >  when only the iterator is accessible. However, in the book
   >  "Contributing to Eclipse" they tell us to use arrays because it's more
   >  efficient and you don't have to cast a lot.
   >  
   >  Interface naming: I would propose to name all interfaces starting with
   >  a capital I and omit the ...Impl for implementation classes. This suits
   >  the Eclipse naming conventions and is more consequent for future
   >  plug-in contributors.
   >  
   >  Johann
   >  
   >  
   >  
   >  -------------------------------------------------------
   >  This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
   >  Project Admins to receive an Apple iPod Mini FREE for your judgement on
   >  who ports your project to Linux PPC the best. Sponsored by IBM.
   >  Deadline: Sept. 13. Go here: http://sf.net/ppc_contest.php
   >  _______________________________________________
   >  jmoney-devel mailing list
   >  jmo...@li...
   >  https://lists.sourceforge.net/lists/listinfo/jmoney-devel
   -------Original Message-------