Re: [Jmol-developers] Refactoring ideas for cleaner code

[Nicolas V. <nve...@gm...>]

I have just committed a simple example of using Enum on the axes mode :

   - Revision 15918 in SVN
   - Changes
   http://bazaar.launchpad.net/~nvervelle/jmol/trunk/revision/11402

If this seems ok, I can try to apply the same principle on other constants.

Nico

On Wed, Aug 3, 2011 at 2:50 AM, Jonathan Gutow <gu...@uw...> wrote:

> This sounds like a good idea.  I would really like to see a way of making
> this clearer to read for future programmers as well.  If this is going to
> undergo a major refactoring we should put some thought into organizing the
> constants in a way that makes it easy to find those you are interested in,
> without have a good idea what they are called.  I think we just need to
> categorize them more carefully.
>
> Jonathan
> On Aug 2, 2011, at 1:03 PM, Nicolas Vervelle wrote:
>
> > Hi,
> >
> > Looking at JmolConstants, I think we could refactor it to have much
> cleaner code in Jmol.
> > I think especially about the list of constants.
> > Since we are now using Java 5 code, what do you think about using Enum ?
> >
> > For example, replacing all the CALLBACK_xxx constants and callbackNames[]
> by an proper Enum in its own file ?
> > And then only using the Enums in the rest of the code.
> > I think it will be cleaner and a lot better for type safety.
> >
> > Nico
> >
> ------------------------------------------------------------------------------
> > BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
> > The must-attend event for mobile developers. Connect with experts.
> > Get tools for creating Super Apps. See the latest technologies.
> > Sessions, hands-on labs, demos & much more. Register early & save!
> > http://p.sf.net/sfu/rim-blackberry-1
> > _______________________________________________
> > Jmol-developers mailing list
> > Jmo...@li...
> > https://lists.sourceforge.net/lists/listinfo/jmol-developers
>
>                         Dr. Jonathan H. Gutow
> Chemistry Department                                gu...@uw...
> UW-Oshkosh                                          Office: 920-424-1326
> 800 Algoma Boulevard                                FAX:920-424-2042
> Oshkosh, WI 54901
>                http://www.uwosh.edu/facstaff/gutow
>
>
>
> ------------------------------------------------------------------------------
> BlackBerry&reg; DevCon Americas, Oct. 18-20, San Francisco, CA
> The must-attend event for mobile developers. Connect with experts.
> Get tools for creating Super Apps. See the latest technologies.
> Sessions, hands-on labs, demos & much more. Register early & save!
> http://p.sf.net/sfu/rim-blackberry-1
> _______________________________________________
> Jmol-developers mailing list
> Jmo...@li...
> https://lists.sourceforge.net/lists/listinfo/jmol-developers
>