From: <ha...@us...> - 2006-04-11 02:43:46
|
Revision: 4951 Author: hansonr Date: 2006-04-10 19:43:39 -0700 (Mon, 10 Apr 2006) ViewCVS: http://svn.sourceforge.net/jmol/?rev=4951&view=rev Log Message: ----------- Back to 20000% maximum zoom. The real issue here is the way perspective depth drives z to incredibly high values. I think perspective depth could be tweaked to make it not so, but for now this is safest. At higher zoom levels we see almost no difference in scale with perspective depth on, but the z values are enormous, and we start seeing what I think are errors due to going over Integer.MAX_VALUE, probably because we are taking z*z somewhere. Modified Paths: -------------- trunk/Jmol/src/org/jmol/viewer/Viewer.java Modified: trunk/Jmol/src/org/jmol/viewer/Viewer.java =================================================================== --- trunk/Jmol/src/org/jmol/viewer/Viewer.java 2006-04-10 17:01:18 UTC (rev 4950) +++ trunk/Jmol/src/org/jmol/viewer/Viewer.java 2006-04-11 02:43:39 UTC (rev 4951) @@ -305,7 +305,21 @@ return transformManager.zoomPercentSetting; } - public final static int MAXIMUM_ZOOM_PERCENTAGE = 500000; + public final static int MAXIMUM_ZOOM_PERCENTAGE = 20000; + /* + * OK, I give. We have a real limitation with perspective depth. + * Zoom is back to where it was. + * When it is on and we go very far past this in zoom, we can see some + * nasty rendering issues. I believe this is because we are hitting + * a point where z*z > int.MAX_VALUE, but I can't be sure. I believe + * that means that the real limit for z is a short. + * + * These notes are meant solely as a guide to development and should be + * removed when the issues relating to them are resolved. + * + * Bob Hanson 4/06 + * + */ void zoomToPercent(int percent) { transformManager.zoomToPercent(percent); This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |