Re: [Jmol-developers] Re: rkanters -> jmol developer

[<rka...@ri...>]

Hi Miguel,

I did had tested the file several times before (but not with a 'clean')=20=

I checked in. I just checked with a ant clean and I still seem to be in=20=

business.

I'll make the modifications using the model.atomCount and check it in=20
(both the Gaussian and NWChem readers).

Ren=E9

On Oct 19, 2004, at 9:41 AM, Miguel wrote:

>
>> Miguel,
>>
>> I think I figured out how to connect to the developer one.
>> I set an alias (since my memory is not particularly good):
>
> Good
>
>> I just tried to check-in the NWChemReader.java (since the
>> Float.parseFloat was still in the version in the repository)
>
> that is a good simple thing to fix as a test
>
>> and this is what happened.
>> BTW I did get bbedit to open a message window, but I wasn't sure what
>> to do there. I added some stuff, hit a save and quit,
>
> you did the right thing
>
>> but I am not sure
>> whether that was the right thing to do (specially since I got that =
Log
>> message thing...)
>
> don't worry about that log message. If you read the content it will =
say
> that the stuff is going to be stripped out.
>
>> [rkanters-mac:jmol/adapter/smarter] rkanters% cvsjmol ci
>> NWChemReader.java
>> rka...@cv...'s password:
>>
>> Log message unchanged or not specified
>> a)bort, c)ontinue, e)dit, !)reuse this message unchanged for =
remaining
>> dirs
>> Action: (continue) c
>
> Unfortunately, this looks like your message did not get saved as=20
> expected.
> Don't know why this would be the case.
>
> You hit continue, so it checked in without a message.
>
> Until we get the bbedit thing resolved, you can do the following
>
> cvs ci -m "eliminated Float.parseFloat()"
>
> Then cvs will take the message from the command line and not open the=20=

> editor.
>
>> Checking in NWChemReader.java;
>> /cvsroot/jmol/Jmol/src/org/jmol/adapter/smarter/NWChemReader.java,v
>> <--  NWChemReader.java
>> new revision: 1.2; previous revision: 1.1
>> done
>
> This looks very good ... all checked in.
>
>> Use of uninitialized value in split at=20
>> /cvsroot/jmol/CVSROOT/ciabot_cvs
>> line 169, <STDIN> line 8.
>> Use of uninitialized value in concatenation (.) or string at
>> /cvsroot/jmol/CVSROOT/ciabot_cvs line 172, <STDIN> line 8.
>> Mailing jmo...@li......
>> Generating notification message...
>> Generating notification message... done.
>> Use of uninitialized value in concatenation (.) or string at
>> /cvsroot/jmol/CVSROOT/ciabot_cvs line 255.
>
> I am not sure what this 'unitialized value' thing is. I suspect that =
it
> *might* be related to the fact that you did not provide a message.
>
> Don't worry, you did great.
>
> Make another small change and check something else in.
>
>
> Separately, one thing to remember, always do an 'ant clean main'
> immediately before checking in.
>
>
> Miguel
>
> -----
> Open Source Molecular Visualization
> www.jmol.org
> mi...@jm...
> -----
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: IT Product Guide on=20
> ITManagersJournal
> Use IT products in your business? Tell us what you think of them. Give=20=

> us
> Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out=20=

> more
> http://productguide.itmanagersjournal.com/guidepromo.tmpl
> _______________________________________________
> Jmol-developers mailing list
> Jmo...@li...
> https://lists.sourceforge.net/lists/listinfo/jmol-developers
>