Menu

#14 small change to random cards

closed-fixed
nobody
None
5
2007-01-13
2007-01-09
Bret
No

I find it somewhat annoying to get the same card twice in a row - I don't retain those cards as well as cards where there is no immediate repetition. Using the 1.0 and 1.1 releases I've been skip repeated cards.

This isn't a bug, but I do find it to be a usability annoyance.

This patch slightly modifies DefaultLearnSession.gotoNextCard() so that it will only repeat a card if it is the last card in its shuffle set.

Discussion

  • Bret

    Bret - 2007-01-09

    Patch to prevent repeated cards

     
  • Riad Djemili

    Riad Djemili - 2007-01-13
    • status: open --> closed-fixed
     
  • Riad Djemili

    Riad Djemili - 2007-01-13

    Logged In: YES
    user_id=853759
    Originator: NO

    I think this is a good idea. I just changed the if-condition to "m_currentCard != null && countNextCards > 1 && countNextCards == m_cards.size()" to make it more precise. This way it should only handle the cases when there are only unlearned cards left to be learned.

    Thanks for your contribution.

     

Log in to post a comment.