Re: [Jikesrvm-researchers] modified preprocessor

[Lingli Z. <lin...@um...>]

Hi Eliot,

Thanks for your suggestions.

Yes, you are right, the syntax of value condition test is
//-#if RVM_FOO hello. Same as boolean tests, it can be constructed with 
other condition tests (both boolean and value) by "||", "!" and "&&".

Conventional "==" and "!=" do seem less confused to me. I am just lazy 
when I added code. :)

I didn't add numerical comparisons because I don't
need that functionality now. Someone maybe will need that and add that.
But I think we'd better be careful about complex directives because it is 
error prone.

The checking of the second '|' and '&' is done by getBoolean().

Anyway, I didn't spend a lot of time on it. I just need the functionality
quickly. Sorry it is not perfect. :) I will refine it later when I have time
if someone hasn't done it yet.


Cheers.
Lingli

Quoting Eliot Moss <mo...@cs...>:

> Lingli -- I found it pretty hard to discern what the syntax is of the
> //#-if construct. The best I could figure out is this:
>      //-if RVM_FOO ralph
> is true if symbol RVM_FOO has the value "ralph". Am I right?
> 
> This needs to be documented in the help string, for one thing. For another,
> it seems all you have added is (effectively) == and != forms, but no
> numerical comparisons (for example). Is that right? Why not use the
> conventional == and != syntax? It would likely be less confusing.
> 
> I also observe that the whole thing does not have a lot of error
> checking. For example, I did not immediately see anything to check that the
> second character of && is really &, and so forth.
> 
> Regards -- Eliot
> _______________________________________________
> Jikesrvm-researchers mailing list
> Jik...@os...
>
http://www-124.ibm.com/developerworks/oss/mailman/listinfo/jikesrvm-researchers
> 


-- 
Lingli Zhang
lin...@um...