Re: [Jikesrvm-core] cross-platform regression builds fail.

[Steven A. <au...@us...>]

I have checked in this change. 

I've also modified jconfigure so that it documents the special exit 
status.  "jbuild" now uses status 111 to declare that things are fine, but 
it needs the linker run.    This is because it was already exiting with 
status 1 in other places, and it seemed easier to use a different special 
value.

When I tested it, there were a couple of minor bugs in cross-platform 
building that had crept into jconfigure; I've fixed 'em.

d--Steve Augart





Chris Hoffmann <hof...@cs...>
Sent by: jik...@ww...
08/04/2003 11:24 AM
Please respond to jikesrvm-core
 
        To:     jikes-core <jik...@ww...>
        cc:     David P Grove/Watson/IBM@IBMUS
        Subject:        [Jikesrvm-core] cross-platform regression builds 
fail.


Another bug: RunSanityTests no longer works properly in a cross-platform
build. 

The problem is that jbuild exits with a result of 1 to flag that it
can't run the linker on the host platform. RunSanityTests sees this as
an error and writes "FAILED" to the semaphore file. When RunSanityTests
is executed on the target platform it sees the "FAILED" string and
aborts.

My patch to RunSanityTests is attached below -- it assumes that an exit
code of 1 means that everything is OK except that the host and target
platforms differ, and thus treats a value of 1 as a special case of
"failure".

[Thanks Dave!]
Chris

===================================================================
RCS file: /usr/cvs/jikesrvm/rvm/regression/RunSanityTests,v
retrieving revision 1.49
diff -u -r1.49 RunSanityTests
--- RunSanityTests               30 Jul 2003 01:39:38 -0000 1.49
+++ RunSanityTests               4 Aug 2003 15:15:30 -0000
@@ -328,7 +328,9 @@
                     say "Building $NAME."
                     say "Output from the build will go into 
${RVM_BUILD}/RVM.trace"
                     ./jbuild -trace -demographics &> RVM.trace || 
failed=$?
-                    if (( failed )); then
+                    if (( failed == 1 )); then
+                                say "Successfully built image for $NAME 
in what must be a
cross-platform build."
+                    elif (( failed )); then
                                 say "FAILED while building $NAME."
                                 say "  See $RVM_BUILD/RVM.trace for 
details"
                     else
@@ -339,7 +341,10 @@
                 if [[ $WAIT ]]; then
                     say "Leaving a wait marker in \"$WAIT\""
                     # Leave a marker to signify the building is done.
-                    if (( failed )); then
+                    if (( failed == 1 )); then
+                                echo "SUCCESS Built boot image for $NAME 
in what must be a
cross-platform build. Must still run jbuild -booter to create
executable."
+                                say "You may remove this file" 
+                    elif (( failed )); then
                                 echo "FAILED to build $NAME at $(date) on 
$(hostname)"
                                 say "  See $RVM_BUILD/RVM.trace for 
details"
                                 say "You may remove this file" 


-- 
Chris Hoffmann -- Dept. of Computer Science/UMass at Amherst
http://www-ali.cs.umass.edu/~hoffmann
_______________________________________________
Jikesrvm-core mailing list
Jik...@ww...
http://www-124.ibm.com/developerworks/oss/mailman/listinfo/jikesrvm-core