From: <jik...@li...> - 2014-03-02 18:02:43
|
details: http://hg.code.sourceforge.net/p/jikesrvm/code/rev/62720fce5306 changeset: 10736:62720fce5306 user: Erik Brangs <eri...@gm...> date: Sun Mar 02 18:26:38 2014 +0100 description: Backout 3410e762619dd70b37569143236dcf90e7ca3e2f (Make the trampolineRegisters field in RVMThread final) The field trampolineRegisters is an entrypoint. It's not advisable to make entrypoints final unless it's absolutely sure that the field won't be changed. There are currently no uses of the corresponding field for trampolineRegisters in the ArchEntrypoints in Jikes RVM. However, downstream code may use it. Therefore, default to not making the field final. diffstat: rvm/src/org/jikesrvm/scheduler/RVMThread.java | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diffs (12 lines): diff --git a/rvm/src/org/jikesrvm/scheduler/RVMThread.java b/rvm/src/org/jikesrvm/scheduler/RVMThread.java --- a/rvm/src/org/jikesrvm/scheduler/RVMThread.java +++ b/rvm/src/org/jikesrvm/scheduler/RVMThread.java @@ -295,7 +295,7 @@ } /** Registers used by return barrier trampoline */ - private final Registers trampolineRegisters = new Registers(); + private Registers trampolineRegisters = new Registers(); /** Return address of stack frame hijacked by return barrier */ private Address hijackedReturnAddress; |