[rvm-commits] code: Fix more problems in checkstylePlugin.xml (thanks to Dave).

[<jik...@li...>]

details:   http://hg.code.sourceforge.net/p/jikesrvm/code/rev/bfc80b668629
changeset: 10699:bfc80b668629
user:      Erik Brangs <eri...@gm...>
date:      Wed Oct 09 20:19:55 2013 +0200
description:
Fix more problems in checkstylePlugin.xml (thanks to Dave).

The ant property verifyproperty of the checksum task must be set to the name of the property and not its contents (see https://ant.apache.org/manual/Tasks/checksum.html).

By default, the fail task checks only if a property is set (or not set). We need to check the contents of the property because we always set it.


diffstat:

 build/checkstylePlugin.xml |  10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diffs (26 lines):

diff --git a/build/checkstylePlugin.xml b/build/checkstylePlugin.xml
--- a/build/checkstylePlugin.xml
+++ b/build/checkstylePlugin.xml
@@ -67,14 +67,20 @@
     <echo message="Checksum for output is   ${plugin.test.output.checksum}"/>
     -->
 
-    <checksum file="${plugin.test.output.txt}" property="${plugin.test.expected.checksum}" verifyproperty="${plugin.test.ok}"/>
+    <checksum file="${plugin.test.output.txt}" property="${plugin.test.expected.checksum}" verifyproperty="plugin.test.ok"/>
 
     <!-- Intended for debugging
     <loadfile property="checkstyle-plugin-test.output" srcFile="${plugin.test.output.txt}"/>
     <echo message="${checkstyle-plugin-test.output}"/>
     -->
 
-    <fail unless="${plugin.test.ok}" message="Tests for the Checkstyle Jikes RVM assertion style plugin failed (checksum mismatch)!"/>
+    <fail message="Tests for the Checkstyle Jikes RVM assertion style plugin failed (checksum mismatch)!">
+      <condition>
+        <not>
+          <istrue value="${plugin.test.ok}"/>
+        </not>
+      </condition>
+    </fail>
   </target>
 
 </project>