From: Erik B. <eri...@gm...> - 2013-07-30 20:03:26
|
Hi, On 25.07.2013 17:14, Carl Ritson wrote: >> Please find attached a patch which implements thread priority on >> RVMThreads at the OS level. This addresses RVM-750. > > Following on from this, classpath does not appropriately query the VM > thread when creating children. [...] > > The attached patch (applied to classpath) fixes this. thanks for the patches. We appreciate your contributions. There was an implementation of RVM-750 in MRP (see http://git.codehaus.org/gitweb.cgi?p=mrp.git;a=commitdiff;h=bee01390c061dfbe746f79bd45affdae94529b33). Could you comment on the different approaches? I looked briefly at your patch and have the following questions/suggestions: -is the code portable enough? IIRC AIX is the only operating system that we support and that you did not test. -Would debugging variables for thread priority (e.g. something comparable to "traceAcct" in RVMThread) be useful? -the code of setPriority() in RVMThread would probably be more readable if the result of the SysCall was saved to its own variable. -the patch contains trailing whitespace (which leads to checkstyle failures). We need contributor statements to apply the patches. You can also provide us with a contributor statement for all contributions (text can be found on the bottom of the "Contributions" wiki page with the other statements). Kind regards, Erik Brangs |