From: Jesenko M. (JEKM) <JE...@r-...> - 2012-06-14 10:53:32
|
Hello all In the company I work for I am in charge of making a fairly extensive modification to the SpiderWebPlot to suit a customer's needs. To do this I have introduced the Category/Value marker classes to this plot, and am now in the process of testing it. My question is what do I need to keep in mind when making modifications to the class? The patch will be released to comply with the license, but it would be very nice if some of the features we introduce make it to the master branch, and therefore I could use some guidelines for what kind of code you accept. Regards Jesenko Mehmedbasic Ramboll Management Consulting |
From: Martin H. <ma...@xs...> - 2012-06-14 11:13:46
Attachments:
signature.asc
|
Hi! Thanks for contributing back to JFreeChart! On 14 Jun 2012, Jesenko Mehmedbasic (JEKM) wrote: > Hello all > > In the company I work for I am in charge of making a fairly extensive > modification to the SpiderWebPlot to suit a customer's needs. > > To do this I have introduced the Category/Value marker classes to this > plot, and am now in the process of testing it. > > My question is what do I need to keep in mind when making modifications > to the class? The patch will be released to comply with the license, but > it would be very nice if some of the features we introduce make it to > the master branch, and therefore I could use some guidelines for what > kind of code you accept. Well, some information is available from this site (section "Patches"): http://www.jfree.org/jfreechart/developers.html Regarding JDK version 1.4 should suffice for now. You can check this by using Maven and AnimalSniffer: http://sourceforge.net/apps/mediawiki/jfreechart/index.php?title=Developer_Information#Building_with_Maven Regarding Code-Style I think you should just have a look at the source and see yourself. I don't think they are written somewhere. If anybody has more recommendations, please reply. Ww should then write this information down on another wiki-page. (I can do this but it could take some time). hth, - martin |
From: David G. <dav...@ob...> - 2012-06-17 21:39:44
|
On 14/06/2012 12:40, Jesenko Mehmedbasic (JEKM) wrote: > Hello all > > In the company I work for I am in charge of making a fairly extensive modification to the SpiderWebPlot to suit a customer's needs. > > To do this I have introduced the Category/Value marker classes to this plot, and am now in the process of testing it. > > My question is what do I need to keep in mind when making modifications to the class? The patch will be released to comply with the license, but it would be very nice if some of the features we introduce make it to the master branch, and therefore I could use some guidelines for what kind of code you accept. > > Regards > Jesenko Mehmedbasic > Ramboll Management Consulting > Hi Jesenko, Your changes will have the most chance to get included if they are backwards compatible (don't break any existing code that uses JFreeChart) and run on JREs back as far as version 1.4. You should also try to ensure that your new objects are serialisable and implement equals() and hashCode() in a sensible way. For source formatting, there is a style.xml file in the checkstyle directory which you can run, but to be honest if your contribution is good we will not mind to reformat it a little to match our existing style. It is more important that your patch doesn't include any gratuitous source reformatting which obscures the real changes in your patch. A good demo application for your changes is a good way to get your patch noticed. :-) Best regards, David |