[jetty-discuss] [jira] Assigned: (JETTY-521) Unit Test Problems on XP

[Jan B. (JIRA) <ji...@co...>]

     [ http://jira.codehaus.org/browse/JETTY-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jan Bartel reassigned JETTY-521:
--------------------------------

    Assignee: David Yu

dyu,

gregw suggests that for the thread count test, it is timing-sensitive, so try upping the interval to make it a less sensitive.

cheers
Jan

> Unit Test Problems on XP 
> -------------------------
>
>                 Key: JETTY-521
>                 URL: http://jira.codehaus.org/browse/JETTY-521
>             Project: Jetty
>          Issue Type: Bug
>    Affects Versions: 6.1.8
>         Environment: Windows XP Professional
>            Reporter: Alex Bradley
>            Assignee: David Yu
>            Priority: Minor
>
> I checked out the 6.1.8 tag and found a couple of minor build problems under XP that prevented Maven from completing:
> 1. All tests extending HttpServerTestBase use an EchoHandler class however the content-length of the returned content is not equal to the content-length of the request content causing the tests to fail. This is due to the fact that the content-length calculation uses bytes for the request but uses characters on the response - on XP, the default line separator of the PrintWriter uses a line-feed + carriage return adding an additional character for each line echoed. I solved this by modifying the constructor:
>     protected HttpServerTestBase(Connector connector)
>     {
>         _connector=connector;
>         System.setProperty("line.separator", "\n");
>     }
> 2. The ThreadPoolTest class has an incorrect test at the end which fails on my machine:
>         assertTrue(tp.getThreads()>5);
> The min number of threads defined in the test is 5 and, when the test gets to this assert(), only 5 threads are active. To fix this, I changed this line to :
>        assertTrue(tp.getThreads()>=5);

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira