Re: [jdee-users] Assorted usability patches

[Len T. <len...@gm...>]

Hi Ludovic,
> In the process of packaging and discovering JDEE as a user, I came up
> with a few patches.  Some of them were meant to facilitate the
> installation and match the file system layout conventions (classifying
> files in a way similar to what GNU configure does), and others are
> usability patches or bug fixes that may be of general use.

I had a quick scan of them now, and will try and look at some of them
in more detail on Monday - I have some initial comments, and would
like to see what others think.

>   * Patches for the installation procedure:
> 
>     1. https://svn.nixos.org/repos/nix/nixpkgs/trunk/pkgs/applications/editors/emacs-modes/jdee/installation-layout.patch

Wouldn't this mean that all those removed properties need to be in the
external build.properties file?  In the antfiles I write I usually
include external properties files at the start of the build.xml
(rather than inside the init target as we currently have in jdee), so
that properties defined in the xml itself are treated as defaults that
can always be overridden. Perhaps we should do that instead?

>     2. https://svn.nixos.org/repos/nix/nixpkgs/trunk/pkgs/applications/editors/emacs-modes/jdee/cedet-paths.patch

I would like to test that this also works when pointing at a
non-system-installed cedet (as I guess many people who build jdee
themselves run like that).

>     3. https://svn.nixos.org/repos/nix/nixpkgs/trunk/pkgs/applications/editors/emacs-modes/jdee/elib-avltree.patch

This looks good - it'd be great to no longer need external avltree as a dependency.

4 through 8 all look good from my quick scan, and should probably go
in, pending a bit of testing.

What do others think?


Cheers,
Len.