From: Marc-Antoine G. <mag...@oc...> - 2004-05-13 14:18:18
|
Ok, i now better understand your need! Let's have a deeper look into this VerifyCaptchaChallengeAction : It begins with : CaptchaService service = CaptchaServicePlugin.getInstance().getService(); //get an id String responseKey = CaptchaServicePlugin.getInstance().getResponseKey(); //we don't care String captchaID; //retrieve an id in order to identify the captcha. captchaID = CaptchaModuleConfigHelper.getId(httpServletRequest); //stuff to construct the message response... ... //call the service Boolean isResponseCorrect = service.validateResponseForID(captchaID, challengeResponse); //stuff to forward ... that's it. I don't think putting all that code in a method simplify the use of the framework because you may need to do insert some code in between. This action VerifyCaptchaChallengeAction has been designed to be an example of the struts plugin usage. You may use it as is or implement your own action. Regards. Marc-Antoine Garrigue > -----Original Message----- > From: jca...@li... > [mailto:jca...@li...] On Behalf > Of Joe Germuska > Sent: jeudi 13 mai 2004 15:38 > To: jca...@li... > Subject: RE: [Jcaptcha-users] New JCaptcha User > > > Thanks for the very detailed guide! > > >Concerning the refactoring, i think it should work but i > don't see the > >point of doing this (actually the plugin is just a configuration > >holder). Have you seen any code duplication? > > The duplication will come as soon as I decide that I don't exactly > care for the way that .VerifyCaptchaChallengeAction and want to do > something about it differently. Or if not me, the next person. It > seems so easy to boil down the verification into a method which can > be used flexibly, either by the VerifyCaptchaChallengeAction or by > any other action. > > One could argue for just pushing the verification out into a method > of VerifyCaptchaChallengeAction, but then one is obligated to extend > that class to use the behavior, and in our designs, we often have > other classes we want to use as parent classes of our actions. > > Make any sense? > > Thanks again, > Joe > > -- > Joe Germuska > Joe@Germuska.com > http://blog.germuska.com > "Imagine if every Thursday your shoes exploded if you > tied them > the usual way. This happens to us all the time with computers, and > nobody thinks of complaining." > -- Jef Raskin > > > ------------------------------------------------------- > This SF.Net email is sponsored by: SourceForge.net Broadband > Sign-up now for SourceForge Broadband and get the fastest > 6.0/768 connection for only $19.95/mo for the first 3 months! http://ads.osdn.com/?ad_id=2562&alloc_id=6184&op=click _______________________________________________ Jcaptcha-users mailing list Jca...@li... https://lists.sourceforge.net/lists/listinfo/jcaptcha-users |