[javascriptlint-commit] SF.net SVN: javascriptlint:[239] trunk

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 454-5900

Revision: 239
          http://javascriptlint.svn.sourceforge.net/javascriptlint/?rev=239&view=rev
Author:   matthiasmiller
Date:     2009-03-04 01:41:05 +0000 (Wed, 04 Mar 2009)

Log Message:
-----------
document bug with </script> inside comment

Modified Paths:
--------------
    trunk/pyjsl/jsparse.py
    trunk/tests/html/script_tag_in_js_literal.html

Added Paths:
-----------
    trunk/tests/html/script_tag_in_js_comment.html

Modified: trunk/pyjsl/jsparse.py
===================================================================

--- trunk/pyjsl/jsparse.py	2009-03-03 17:02:59 UTC (rev 238)
+++ trunk/pyjsl/jsparse.py	2009-03-04 01:41:05 UTC (rev 239)
@@ -367,6 +367,8 @@
         )
         for text, result in tests:
             self.assertEquals(is_compilable_unit(text), result)
+        # NOTE: This seems like a bug.
+        self.assert_(is_compilable_unit("/* test"))
 
 class TestLineOffset(unittest.TestCase):
     def testErrorPos(self):

Copied: trunk/tests/html/script_tag_in_js_comment.html (from rev 237, trunk/tests/html/script_tag_in_js_literal.html)
===================================================================
--- trunk/tests/html/script_tag_in_js_comment.html	                        (rev 0)
+++ trunk/tests/html/script_tag_in_js_comment.html	2009-03-04 01:41:05 UTC (rev 239)
@@ -0,0 +1,12 @@
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN">
+<html>
+<head>
+    <title>JavaScript Lint Test Page</title>
+    <script type="text/javascript"><!--
+        /* alert the </script> end tag */ /*warning:unterminated_comment*/
+    //-->
+    </script>
+</head>
+<body>
+</body>
+</html> 

Modified: trunk/tests/html/script_tag_in_js_literal.html
===================================================================
--- trunk/tests/html/script_tag_in_js_literal.html	2009-03-03 17:02:59 UTC (rev 238)
+++ trunk/tests/html/script_tag_in_js_literal.html	2009-03-04 01:41:05 UTC (rev 239)
@@ -3,7 +3,7 @@
 <head>
     <title>JavaScript Lint Test Page</title>
     <script type="text/javascript"><!--
-        /* alert the </script> end tag */
+        /*jsl:declare window*/
         var x = "</script>";
         window.alert(x);
     //-->


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.


