[Irrlicht-tracker-update] [ irrlicht-Patches-2843635 ] Patch for the Animated Bounding Boxes bug

[SourceForge.net <no...@so...>]

Patches item #2843635, was opened at 2009-08-24 17:49
Message generated for change (Settings changed) made by hybrid
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540678&aid=2843635&group_id=74339

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
>Category: scene
Group: None
>Status: Closed
>Resolution: Fixed
>Priority: 6
Private: No
Submitted By: Steel Style (steelstyle)
Assigned to: Nobody/Anonymous (nobody)
Summary: Patch for the Animated Bounding Boxes bug

Initial Comment:
Bug Thread : https://sourceforge.net/tracker/?func=detail&aid=2799162&group_id=74339&atid=540676

Explanation :
Irrlicht actualy use the last bounding box to compute if a scene node is visible,
and so if this scene node is not visible we don't have to render it wich mean
don't have to skin it. ( Skinning computation is rather expensive).
But the problem is that we update bounding box at the end of Animate wich
was "useless".

The problem is that we are updating bouding box before the skinning.

We should also get rid of the updateBoundingBox on animateMesh() 
wich is (as I see) alway before the skinMesh() since it's not used between this 2 calls.

PS : The better method would be doing some change to updateBoundingBox also or create another update fonctiun.
Rogerborg did the change and as we can see he add buffersUsed[weight.buffer_id]->boundingBoxNeedsRecalculated();
(line 512) CSkinnedMesh;
This way we will update only the bounding box who need it.



----------------------------------------------------------------------

Comment By: Christian Stehno (hybrid)
Date: 2009-11-08 23:50

Message:
This patch has been accepted and commited to SVN. It will be part of the
next release.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540678&aid=2843635&group_id=74339