Re: [Ipsec-tools-devel] Updated FreeBSD NAT-T patches

[VANHULLEBUS Y. <va...@fr...>]

On Fri, Apr 29, 2005 at 11:08:16AM -0400, Larry Baird wrote:
> Yvan,
> 
> > I just made a *really quick* review of the diff between a sys tree +
> > "official" patch and a sys tree with your new version of the patch.
> > 
> > You should at least do a sed /IPSEC_NAT_T/ENABLE_NATT/ on the source
> > tree, or a sed /ENABLE_NATT/IPSEC_NAT_T/ if you want, or something
> > else, I don't know, but at least to have a single define for all NAT-T
> > code in the kernel !!!
> As I emailed you before I like the option name IPSEC_NAT_T much better
> than ENABLE_NATT.  Feel free to make this change in the patch.  I'll
> do the same.

Yes, IPSEC_NAT_T may be a better choice, I'll clean up that during the
review...


> > I'll try to do some more checks on that patch (without FAST_IPSEC, but
> > with multiple IPSEC peers behind the same IP) on next days, then
> > commit it, as it seems to work with FAST_IPSEC.
> What do you mean by commit it?

Commiting on the htdoc CVS, which is the base repository for the web
site, where the patch can currently be found.

And we should do "something" to make such patches more easy to find...


Yvan.