From: Preggna S <spr...@no...> - 2006-05-09 05:42:40
|
Hi Yvan, Thanks for the comments on my patch. I am resubmitting the modified = patches with your comments incorporated. Please find attached the = following patches: (1) adminport.patch *->patch[01/07]was :VPN Client Framework - registration= /dispatch design (2) addr_range.patch *>patch[02/07]was :VPN Client Framework - registratio= n/dispatch design >> 1. Admin Port changes=20 >I did NOT commit this patch for now, for various reasons: > >- it lacks examples / updated man page, so I didn't understood what it > is supposed to do. Have updated the verbs with comments, which would help in understanding = these verbs. - Example usage can be found at the Turnpike client code @=20 http://forge.novell.com/modules/xfmod/project/?turnpike=20 - I was not able to locate the man page for admin port verbs. = Would be good if you can give me pointers on this, which would in turn help me add the documentation= for the new admin port verbs. - Have removed the TURNPIKE specific code path. Will resubmit just = the TURNPIKE specific part of this again. =09 >- There are some code portions in #if 0, or with comments like > "changes to be made".... Sorry about this. Have removed the same. >- in admin.c, you declared policyin/out as char*, but ipsec_set_policy > returns ipsec_policy_t. Have corrected. >- in localconf.c you have a dangerous (racoon_conf !=3D LC_DEFAULT_CF) > test, where racoon_conf is a char* and LC_DEFAULT_CF is a string > define !! Have corrected with few modifications. >- Some sprintf() should be changed to snprintf(), or comments should > be added to explain how you can be sure that size of the buffer will > NEVER be reached. Have corrected. >> 2. Address range changes >I added the "addres range" changes, but NOT the TURNPIKE code included >in it, as it is separate stuff. > >It would be easier for me to have really separate patches for separate >features, and to review the TURNPIKE patch alone. Right. Have resubmitted the address range patch (a) without the TURNPIKE code (b) and with a small bug fix in get_ipsecdoi_id() function >> 5. Misc >Commited. Thank you.... Thanks a lot again for taking time to review these patches. =20 All changes submitted are against HEAD.=20 thanks & regards, Preggna |