From: Zdenek S. <st...@us...> - 2013-06-02 12:58:50
|
Update of /cvsroot/ipmitool/ipmitool/lib In directory sfp-cvs-1.v30.ch3.sourceforge.com:/tmp/cvs-serv9946/lib Modified Files: ipmi_dcmi.c Log Message: ID: 3612237 - If DCMI command fails, incorrect completion code is printed If any DCMI command fails, the function chk_rsp() in ipmi_dcmi.c displays the incorrect byte as the completion code. $ ipmitool dcmi power activate DCMI request failed because: Unspecified error (dc) The "dc" value printed is actually the "Group extension identification" byte which *always* has the value 0xdc for DCMI responses. Commit for Rob Swindell Index: ipmi_dcmi.c =================================================================== RCS file: /cvsroot/ipmitool/ipmitool/lib/ipmi_dcmi.c,v retrieving revision 1.9 retrieving revision 1.10 diff -C2 -d -r1.9 -r1.10 *** ipmi_dcmi.c 2 Jun 2013 12:51:05 -0000 1.9 --- ipmi_dcmi.c 2 Jun 2013 12:58:47 -0000 1.10 *************** *** 380,388 **** if ((rsp->ccode >= 0x80) && (rsp->ccode <= 0x8F)) { lprintf(LOG_ERR, "\n DCMI request failed because: %s (%x)", ! val2str(rsp->ccode, dcmi_ccode_vals), rsp->data[0]); return 1; } else if (rsp->ccode > 0) { lprintf(LOG_ERR, "\n DCMI request failed because: %s (%x)", ! val2str(rsp->ccode, completion_code_vals), rsp->data[0]); return 1; } --- 380,388 ---- if ((rsp->ccode >= 0x80) && (rsp->ccode <= 0x8F)) { lprintf(LOG_ERR, "\n DCMI request failed because: %s (%x)", ! val2str(rsp->ccode, dcmi_ccode_vals), rsp->ccode); return 1; } else if (rsp->ccode > 0) { lprintf(LOG_ERR, "\n DCMI request failed because: %s (%x)", ! val2str(rsp->ccode, completion_code_vals), rsp->ccode); return 1; } |